|
| Author |
Message |
wmcbrine

Joined: 04 Jan 2008 Posts: 514
|
Posted: Wed Jan 09, 2008 3:12 am Post subject: |
|
|
| wmcbrine wrote: | OK, I put dlfl's patch for the star rating in my repository. But so far, I can't get mpaaRating to work. :/ |
OK, I've got mpaaRating going now. For some reason, this is one of the fussiest fields, and if you get it wrong, it trashes all the other extended data.
There were two issues: First, it will not work in the presence of an "originalAirDate" tag. (And pyTivo was setting this automatically even if it wasn't in the metadata.) Second, unlike the TV and star ratings, both the numeric value and the textual description are significant, and must match. Luckily for us, it only seems to check the first character. So the valid ratings are "G1", "P2", "P3", "R4", "X5", and "N6". "N5" also works, as a synonym for "X5".
What I've done is to suppress the generation of the originalAirDate tag if a "movieYear" tag is present. This means you have to declare both movieYear and mpaaRating to get the mpaaRating to show. Oh, so yeah, that means I've also added support for "movieYear". (You don't have to specify the mpaaRating if you specify movieYear, just vice versa.)
Changes in the usual place.
|
|
| Back to top |
|
 |
MasterCephus

Joined: 04 Jan 2008 Posts: 173 Location: Hueytown, AL
|
Posted: Wed Jan 09, 2008 7:48 am Post subject: |
|
|
Great!
I'll hopefully have some time at the end of the week to add this to the MetaGenerator application.
Good work on this!
EDIT:
Also, is there any method/way we have to get your changes for this into the primary release?
_________________ MetaGenerator
pyTivo Manager |
|
| Back to top |
|
 |
MasterCephus

Joined: 04 Jan 2008 Posts: 173 Location: Hueytown, AL
|
Posted: Fri Jan 11, 2008 4:00 pm Post subject: MetaGenerator is broken right now for movies |
|
|
Apparently I just noticed that the place where I get movie data changed their interface so the movie part of the MetaGenerator is not working.
I know how to fix it, but it might be Monday before I can produce and update because of family obligations this weekend. I will do my best to produce the fix ASAP.
_________________ MetaGenerator
pyTivo Manager |
|
| Back to top |
|
 |
philhu
Joined: 04 Jan 2008 Posts: 122
|
Posted: Fri Jan 11, 2008 4:13 pm Post subject: |
|
|
Thats ok, take your time..
Family and things come first.
We appreciate all the stuff you've done!
phil
|
|
| Back to top |
|
 |
krkeegan Site Admin

Joined: 04 Jan 2008 Posts: 412 Location: Los Angeles, CA
|
Posted: Mon Jan 14, 2008 11:28 pm Post subject: Small Bug |
|
|
Line endings need to be removed or escaped before writing to the metadata file. Particularly in the description field.
I attached a metadata file of an episode of the wire. As you can see there is a line break in the description field. This causes errors in the metadata. The matching entry in the TVDB can be found here:
http://tvdb.zsori.com/?tab=episode&seriesid=79126&seasonid=16065&id=303061&lid=7
Thanks for the great work.
Kevin
| Description: |
|
 Download |
| Filename: |
Wire,_The_-_3x8_-_Moral_Midgetry.English.TOPAZ.DVD.avi.txt |
| Filesize: |
2.02 KB |
| Downloaded: |
55 Time(s) |
|
|
| Back to top |
|
 |
MasterCephus

Joined: 04 Jan 2008 Posts: 173 Location: Hueytown, AL
|
Posted: Tue Jan 15, 2008 5:45 am Post subject: |
|
|
for the mpaa rating, the list is mapped like this (clarify for me):
G -> G1
PG -> P2
PG-13 -> P3
R -> R4
then what else?
Also, what is the year for movieYear? Is it just "2008" or is it in some other format?
_________________ MetaGenerator
pyTivo Manager |
|
| Back to top |
|
 |
philhu
Joined: 04 Jan 2008 Posts: 122
|
Posted: Tue Jan 15, 2008 7:21 am Post subject: |
|
|
| MasterCephus wrote: | for the mpaa rating, the list is mapped like this (clarify for me):
G -> G1
PG -> P2
PG-13 -> P3
R -> R4
then what else?
Also, what is the year for movieYear? Is it just "2008" or is it in some other format? |
MovieYear is just the 4-digit number
|
|
| Back to top |
|
 |
wmcbrine

Joined: 04 Jan 2008 Posts: 514
|
Posted: Tue Jan 15, 2008 1:27 pm Post subject: |
|
|
| MasterCephus wrote: | for the mpaa rating, the list is mapped like this (clarify for me):
G -> G1
PG -> P2
PG-13 -> P3
R -> R4
then what else? |
X -> X5, NC-17 -> N6
| Quote: | Also, what is the year for movieYear? Is it just "2008" or is it in some other format? |
That's it.
movieYear: 2008
mpaaRating: P3
_________________ My pyTivo fork |
|
| Back to top |
|
 |
philhu
Joined: 04 Jan 2008 Posts: 122
|
Posted: Tue Jan 15, 2008 3:06 pm Post subject: Re: MetaGenerator is broken right now for movies |
|
|
| MasterCephus wrote: | Apparently I just noticed that the place where I get movie data changed their interface so the movie part of the MetaGenerator is not working.
I know how to fix it, but it might be Monday before I can produce and update because of family obligations this weekend. I will do my best to produce the fix ASAP. |
This get fixed yet? Any word?
|
|
| Back to top |
|
 |
MasterCephus

Joined: 04 Jan 2008 Posts: 173 Location: Hueytown, AL
|
Posted: Tue Jan 15, 2008 3:33 pm Post subject: 1.3 Released |
|
|
Yes sorry. I published it, but didn't tell anyone
This could have some errors because I haven't tested it thoroughly at all...so if you find something, let me know and I will try to get a fix out as fast as possible...
NEW VERSION: 1.3
added features:
-added year to movie result list
-added ability to convert IMDB rating to stars (can be set in settings)
-add ability to manually add original airdate
-added ability to get the movie year
-added ability to manually add episode number to TV shows
-added mpaaRating
-if a TV show, tvRating is used, if movie, mpaaRating is used
-added mpeg to video filter when looking for video files
-fixed end of line characters in descriptions
_________________ MetaGenerator
pyTivo Manager |
|
| Back to top |
|
 |
reneg
Joined: 04 Jan 2008 Posts: 41
|
Posted: Wed Jan 16, 2008 7:59 am Post subject: |
|
|
| Can you please consider including a version number within your application as well as on the distribution zip file? Now that the 1/15/2008 dated version of metagenerator.exe is dependant on a specific release of wmcbrine latest pytivo (link would be helpful as I assume it is different that the release linked off http://pytivo.armooo.net/), it will require more diligence to keep these applications in sync.
|
|
| Back to top |
|
 |
MasterCephus

Joined: 04 Jan 2008 Posts: 173 Location: Hueytown, AL
|
Posted: Wed Jan 16, 2008 12:38 pm Post subject: |
|
|
Well the reason is that wmcbrine and I have been back and forth and he has allowed in pyTivo some of the metadata features in here.
Hopefully all of his stuff will be put into the main branch (if his isn't already) so all versions from this point will have this new stuff.
_________________ MetaGenerator
pyTivo Manager |
|
| Back to top |
|
 |
Guest
|
Posted: Wed Jan 16, 2008 5:51 pm Post subject: Re: 1.3 Released |
|
|
| MasterCephus wrote: | Yes sorry. I published it, but didn't tell anyone
This could have some errors because I haven't tested it thoroughly at all...so if you find something, let me know and I will try to get a fix out as fast as possible... |
Found a problem for titles with an apostrophy. I could not get a hit on "The General's Daughter" using a variety of combinations such as "daughter" "generals daughter" and "the daughter", etc...
Yep, the title comes up if I do a search on the site.
-Chris
|
|
| Back to top |
|
 |
rjmitche
Joined: 04 Jan 2008 Posts: 33
|
Posted: Wed Jan 16, 2008 7:12 pm Post subject: |
|
|
Just installed the latest version of MetaGenerator and I'm getting an error with the Movies functionality (TV Shows seems to be fine). I enter a search string, get a list of movies back (with the year in the results list... nice touch!) but, when I choose a movie I get an unhandled exception error every time:
"Expression must evaluate to a node-set."
Here are the details: | Code: | ************** Exception Text **************
System.Xml.XPath.XPathException: Expression must evaluate to a node-set.
at MS.Internal.Xml.XPath.XPathParser.ParseNodeTest(AstNode qyInput, AxisType axisType, XPathNodeType nodeType)
at MS.Internal.Xml.XPath.XPathParser.ParseStep(AstNode qyInput)
at MS.Internal.Xml.XPath.XPathParser.ParseRelativeLocationPath(AstNode qyInput)
at MS.Internal.Xml.XPath.XPathParser.ParseRelativeLocationPath(AstNode qyInput)
at MS.Internal.Xml.XPath.XPathParser.ParseLocationPath(AstNode qyInput)
at MS.Internal.Xml.XPath.XPathParser.ParsePathExpr(AstNode qyInput)
at MS.Internal.Xml.XPath.XPathParser.ParseUnionExpr(AstNode qyInput)
at MS.Internal.Xml.XPath.XPathParser.ParseUnaryExpr(AstNode qyInput)
at MS.Internal.Xml.XPath.XPathParser.ParseMultiplicativeExpr(AstNode qyInput)
at MS.Internal.Xml.XPath.XPathParser.ParseAdditiveExpr(AstNode qyInput)
at MS.Internal.Xml.XPath.XPathParser.ParseRelationalExpr(AstNode qyInput)
at MS.Internal.Xml.XPath.XPathParser.ParseEqualityExpr(AstNode qyInput)
at MS.Internal.Xml.XPath.XPathParser.ParseAndExpr(AstNode qyInput)
at MS.Internal.Xml.XPath.XPathParser.ParseOrExpr(AstNode qyInput)
at MS.Internal.Xml.XPath.XPathParser.ParseXPathExpresion(String xpathExpresion)
at System.Xml.XPath.XPathExpression.Compile(String xpath, IXmlNamespaceResolver nsResolver)
at System.Xml.XPath.XPathNavigator.Select(String xpath)
at System.Xml.XmlNode.SelectNodes(String xpath)
at MetaGenerator.Form1.btnMovieSelect_Click(Object sender, EventArgs e)
at System.Windows.Forms.Control.OnClick(EventArgs e)
at System.Windows.Forms.Button.OnClick(EventArgs e)
at System.Windows.Forms.Button.OnMouseUp(MouseEventArgs mevent)
at System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks)
at System.Windows.Forms.Control.WndProc(Message& m)
at System.Windows.Forms.ButtonBase.WndProc(Message& m)
at System.Windows.Forms.Button.WndProc(Message& m)
at System.Windows.Forms.Control.ControlNativeWindow.OnMessage(Message& m)
at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m)
at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)
************** Loaded Assemblies **************
mscorlib
Assembly Version: 2.0.0.0
Win32 Version: 2.0.50727.832 (QFE.050727-8300)
CodeBase: file:///C:/WINDOWS/Microsoft.NET/Framework/v2.0.50727/mscorlib.dll
----------------------------------------
MetaGenerator
Assembly Version: 1.0.0.0
Win32 Version: 1.0.0.0
CodeBase: file:///C:/Program%20Files/MetaGenerator/MetaGenerator.exe
----------------------------------------
System.Windows.Forms
Assembly Version: 2.0.0.0
Win32 Version: 2.0.50727.832 (QFE.050727-8300)
CodeBase: file:///C:/WINDOWS/assembly/GAC_MSIL/System.Windows.Forms/2.0.0.0__b77a5c561934e089/System.Windows.Forms.dll
----------------------------------------
System
Assembly Version: 2.0.0.0
Win32 Version: 2.0.50727.832 (QFE.050727-8300)
CodeBase: file:///C:/WINDOWS/assembly/GAC_MSIL/System/2.0.0.0__b77a5c561934e089/System.dll
----------------------------------------
System.Drawing
Assembly Version: 2.0.0.0
Win32 Version: 2.0.50727.832 (QFE.050727-8300)
CodeBase: file:///C:/WINDOWS/assembly/GAC_MSIL/System.Drawing/2.0.0.0__b03f5f7f11d50a3a/System.Drawing.dll
----------------------------------------
System.Xml
Assembly Version: 2.0.0.0
Win32 Version: 2.0.50727.832 (QFE.050727-8300)
CodeBase: file:///C:/WINDOWS/assembly/GAC_MSIL/System.Xml/2.0.0.0__b77a5c561934e089/System.Xml.dll
----------------------------------------
System.Configuration
Assembly Version: 2.0.0.0
Win32 Version: 2.0.50727.832 (QFE.050727-8300)
CodeBase: file:///C:/WINDOWS/assembly/GAC_MSIL/System.Configuration/2.0.0.0__b03f5f7f11d50a3a/System.Configuration.dll
---------------------------------------- |
|
|
| Back to top |
|
 |
danimal4326 Guest
|
Posted: Wed Jan 16, 2008 11:52 pm Post subject: |
|
|
Just downloaded the latest version..
I'm not seeing the movie year field being inserted into the metadata file.
Also, in the "view metadata' window, the IMDB stars rating is always showing 3.0, but when I look in the generated file, the field says 5.0
|
|
| Back to top |
|
 |
|