pyTivo Discussion Forum Forum Index pyTivo Discussion Forum
Answers and the development of pyTivo a TiVo transcoding server
 
 FAQFAQ   SearchSearch   MemberlistMemberlist   UsergroupsUsergroups   RegisterRegister 
 ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 

Movies shouldn't have an episodeTitle
Goto page Previous  1, 2
 
Post new topic   Reply to topic    pyTivo Discussion Forum Forum Index -> pyTivo
 View previous topic :: View next topic  
Author Message
krkeegan
Site Admin


Joined: 04 Jan 2008
Posts: 412
Location: Los Angeles, CA

PostPosted: Tue May 06, 2008 9:46 pm    Post subject: Reply with quote

I don't know I need more guidance or time to research the proper settings.

episodeTitle and seriesTitle are pretty self explanatory. But I am confused on Title, it appears to always be set to the seriesTitle and I imagine set to the movie title for movies. But I cant be sure yet. And I don't know how changes to title will affect what appears when viewing things on the TiVo.

But yes, I imagine that some change will be necessary once I figure this out. Thanks for the hard work.
Back to top
View user's profile Send private message Visit poster's website
PeteTV



Joined: 25 Jan 2008
Posts: 13

PostPosted: Tue May 06, 2008 11:43 pm    Post subject: Reply with quote

krkeegan wrote:
OK, so we use:
seriesTitle
episodeTitle
Title

So Title looks like it is equal to seriesTitle for TV shows. What is title set to for movies(I don't have any on my machine right now)?


For testing, make sure "title" and "seriesTitle" are different and neither is the same as the filename.

I just upgrade to the VERY latest wgw snapshot (http://repo.or.cz/w/pyTivo/wgw.git?a=snapshot;h=a6cae19ed779d2caff9897c88b7e3ca5b5f81855;sf=tgz). BUT, I also need to apply this patch to TvBus.tmpl....

Code:

--- pyTivo-wgw-20080507/plugins/video/templates/TvBus.tmpl      2008-05-06 19:35:40.000000000 -0700
+++ pyTivo/plugins/video/templates/TvBus.tmpl      2008-05-06 18:55:11.000000000 -0700
@@ -119,7 +119,9 @@
             #end for
       </vDirector>
       <episodeNumber>$escape($video.episodeNumber)</episodeNumber>
-      <episodeTitle>$escape($video.title)</episodeTitle>
+      #if $video.episodeTitle
+      <episodeTitle>$escape($video.episodeTitle)</episodeTitle>
+      #end if
       <vExecProducer>
             #for $element in $video.vExecProducer
             <element>$escape($element)</element>
@@ -167,7 +169,7 @@
       #if $video.starRating
       <starRating value="$video.starRating[1]">$video.starRating[0]</starRating>
       #end if
-      <title>$escape($video.seriesTitle)</title>
+      <title>$escape($video.title)</title>
       <vWriter>
             #for $element in $video.vWriter
             <element>$escape($element)</element>


With this patch... it doesn't appear "seriesTitle" is used at all.

For a movie, all that's needed is "title". If "seriesTitle" is set and "title" is NOT set, then it ignores "seriesTitle" and uses the filename. If "title" IS set, then it uses it.

For a TV show, "title" and "episodeTitle" are needed. If "seriesTitle" is set and "title" is NOT set, the filename is used.

Perhaps the code could look for "title" first and if it's not defined look for "seriesTitle". If "seriesTitle" is defined (and "title" is not), then "title" could be set to the value of "seriesTitle". If neither is set, then "title" could be set to the filename.
Back to top
View user's profile Send private message
MasterCephus



Joined: 04 Jan 2008
Posts: 156
Location: Hueytown, AL

PostPosted: Wed May 07, 2008 3:44 am    Post subject: Reply with quote

Why can't pyTivo just look for the isEpisode flag? If it exists (which it should if they are using my MetaGenerator), then you can tell whether the file is a TV Show or a movie. If it's a movie, you only use title. If it's a TV show, you only use seriesTitle and title. heck you could then check if episodeTitle exists and if it does, override title with episodeTitle.

That would be my suggestion

_________________
MetaGenerator
pyTivo Manager
Back to top
View user's profile Send private message
philhu



Joined: 04 Jan 2008
Posts: 121

PostPosted: Wed May 07, 2008 8:12 am    Post subject: Reply with quote

MasterCephus wrote:
Why can't pyTivo just look for the isEpisode flag? If it exists (which it should if they are using my MetaGenerator), then you can tell whether the file is a TV Show or a movie. If it's a movie, you only use title. If it's a TV show, you only use seriesTitle and title. heck you could then check if episodeTitle exists and if it does, override title with episodeTitle.

That would be my suggestion


The 'isEpisode' flag means more than is it a tv show. If you have a TV Show that is a special and not recurring, isEpisode should be off

Also, other items, like 'Paid Programming', 'Election Coverage' etc are not marked with isEpisode.
Back to top
View user's profile Send private message
PeteTV



Joined: 25 Jan 2008
Posts: 13

PostPosted: Wed May 07, 2008 8:54 am    Post subject: Reply with quote

MasterCephus wrote:
Why can't pyTivo just look for the isEpisode flag? If it exists (which it should if they are using my MetaGenerator), then you can tell whether the file is a TV Show or a movie. If it's a movie, you only use title. If it's a TV show, you only use seriesTitle and title. heck you could then check if episodeTitle exists and if it does, override title with episodeTitle.

That would be my suggestion


This seems a bit confusing based on what I'm seeing. From what I can tell on my TiVo (S3 - 9.3a), "title" should not be set to "episodeTitle", "title" should be the series title... and the info displayed in the TiVo "Program Details" seems to confirm this. (NOTE: using latest wgw PLUS patch previously listed).

If I look at the "Program Details" of a movie recorded by the TiVo, it shows only "Title". If I look at the "Program Details" of a TV show recorded by the TiVo, it shows only "Title" and "Episode Title".

If I look at the "Program Details" of a movie uploaded via pyTivo that only contains "title" in the metafile, then it looks exactly like a movie recorded by the TiVo. If I look at the "Program Details" of a TV show uploaded via pyTivo that only contains "title" and "episodeTitle" in the metafile, then it also looks exactly like a TV show recorded by the TiVo.

It looks to me like the only useful purpose for "seriesTitle" in the metafile would be because the keyword itself makes more sense and possibly for backwards metafile compatibility.

So... regardless if the metafile refers to a movie or a TV show, it seems to me this should work:

1. If "title" exists in the metafile, set the "title" tag in TvBus.tmpl to "title".
2. If "seriesTitle" exists in the metafile (AND "title" does not), set the "title" tag in TvBus.tmpl to "seriesTitle".
3. If neither "title" nor "seriesTitle" exist in metafile, set the "title" tag in TvBus.tmpl to the filename.

"episodeTitle" doesn't need to be handled special at all. If it exists, then set the "episodeTitle" tag in TvBus.tmpl. It shouldn't be set for a movie, so it doesn't need any other special treatment.
Back to top
View user's profile Send private message
krkeegan
Site Admin


Joined: 04 Jan 2008
Posts: 412
Location: Los Angeles, CA

PostPosted: Wed May 07, 2008 12:19 pm    Post subject: Reply with quote

seriesTitle is used by TiVo in the more detailed TVBus XML. But I agree with your assesments of the QueryContainer XML.
Back to top
View user's profile Send private message Visit poster's website
PeteTV



Joined: 25 Jan 2008
Posts: 13

PostPosted: Wed May 07, 2008 1:26 pm    Post subject: Reply with quote

krkeegan wrote:
seriesTitle is used by TiVo in the more detailed TVBus XML. But I agree with your assesments of the QueryContainer XML.


Yes... in fact the "seriesTitle" TAG in TvBus.tmpl is required... at least for movies. Oddly, it doesn't seem to be needed for TV shows (ie, removing it from TvBus.tmpl does change how a movie is displayed, but doesn't make a difference as to how a TV show is displayed).

I tried to differentiate between the "seriesTitle" keyword used in the metadata file and the "seriesTitle" TAG used in TvBus.tmpl, but perhaps I didn't do a very good job.

I was mainly trying to point out 2 things:

1) The "seriesTitle" keyword in the metadata file is not needed.
2) The "title" keyword in the metadata file should be the title of the series, not the title of the episode.

From the average pyTivo users perspective, they only see the contents of the metadata file and the results on the TiVo. From that perspective, the "NPL->Program->Program Details" shows only "Title" for a movie and "Title/Episode Title" for a TV show. Likewise it seems logical the metadata file should contain only the "title" keyword for a movie and "title/episodeTitle" keywords for a TV show.

That said.. it certainly seems like it should be possible to ALLOW the "seriesTitle" keyword in the metadata file as long as it is used as an alternative to the "title" keyword, but does not override the "title" keyword if present.
Back to top
View user's profile Send private message
rjmitche



Joined: 04 Jan 2008
Posts: 30

PostPosted: Sun May 18, 2008 4:48 pm    Post subject: Reply with quote

Did this ever get sorted out? I got kinda lost as mods were made to both pyTivo and MetaGenerator... are the latest versions (I'm currently using the Windows installer) of each behaving correctly?
Back to top
View user's profile Send private message
PeteTV



Joined: 25 Jan 2008
Posts: 13

PostPosted: Sat May 24, 2008 5:03 pm    Post subject: Reply with quote

rjmitche wrote:
Did this ever get sorted out? I got kinda lost as mods were made to both pyTivo and MetaGenerator... are the latest versions (I'm currently using the Windows installer) of each behaving correctly?


Nope... at least not in the wgw version.

I just checked the latest version (http://repo.or.cz/w/pyTivo/wgw.git?a=snapshot;h=906e584b9ce8c7e60664c5a41a6c7589f2a72842;sf=tgz) and it does not contain the TvBus.tmpl changes outlined earlier in this thread.
Back to top
View user's profile Send private message
rjmitche



Joined: 04 Jan 2008
Posts: 30

PostPosted: Mon May 26, 2008 5:18 am    Post subject: Reply with quote

I did some testing (see here) and agree that things aren't quite right yet.

I applied your changes to TvBus.tmpl (Windows installer version) and that seemed to do the trick for movies but, now, I'm not sure there isn't something slightly amiss with TV episodes. I'll need to play around a bit more to be sure though.
Back to top
View user's profile Send private message
etienne66



Joined: 02 Apr 2008
Posts: 7

PostPosted: Thu May 29, 2008 3:05 pm    Post subject: Reply with quote

I dowloaded the krkeegan 05/07/2008 snapshot. Only half of the changes necessary were made. That is why it is not working properly. I will attach my TvBus.tmpl which has all of the changes made.

In my original post you will note that I said that there were two instances of each change that need to be made for a total of 4 changes. Only the first set were changed. I guess I did not make myself very clear and I appologize for that.

The seriesTitle is used in this one, but I have never seen where Tivo shows it to the user. If you query the Tivo though, via https, for a recorded episode it will have it and it is typically the same as the title.

Thanks,
Etienne



TvBus.zip
 Description:
Corrected TvBus.tmpl

Download
 Filename:  TvBus.zip
 Filesize:  1.41 KB
 Downloaded:  26 Time(s)

Back to top
View user's profile Send private message
spirko



Joined: 16 Jun 2008
Posts: 2

PostPosted: Mon Jun 16, 2008 9:51 am    Post subject: Finally happy with titles Reply with quote

I fought with this for a few hours this weekend, and I agree (not that I'm anybody) with etienne66's proposed TvBus.tmpl (attached above).

etienne66 wrote:
I dowloaded the krkeegan 05/07/2008 snapshot. Only half of the changes necessary were made. That is why it is not working properly. I will attach my TvBus.tmpl which has all of the changes made.


With this TvBus.tmpl, the metadata file should contain a title (unless your filename is okay), and for TV shows only, it should contain an episodeTitle.

pyTivo then has the following behavior (on my S2 TiVo):

With episodeTitle, that is shown in quotes in the program list. The screen for a particular episode shows the title at the top and the episodeTitle in quotes before (year from originalAirDate).

Without an episodeTitle, the title is shown without quotes in the program list. The screen for the movie has the title at the top and nothing in quotes before (movieYear).

The seriesTitle is still fed to the TiVo in a <seriesTitle> field for both movies and TV shows, but as etienne66 said, it's not normally visible. Since it has a valid default (the filename), it's not necessary in the metadata file.
Back to top
View user's profile Send private message
Display posts from previous:   
Post new topic   Reply to topic    pyTivo Discussion Forum Forum Index -> pyTivo All times are GMT - 8 Hours
Goto page Previous  1, 2
Page 2 of 2

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You can download files in this forum
Site is in NO WAY affiliated with TiVo Inc

Powered by phpBB © 2001, 2005 phpBB Group
phpBB SEO
[ Time: 0.2352s ][ Queries: 15 (0.1116s) ][ Debug on ]