pyTivo Discussion Forum Forum Index pyTivo Discussion Forum
Answers and the development of pyTivo a TiVo transcoding server
 
 FAQFAQ   SearchSearch   MemberlistMemberlist   UsergroupsUsergroups   RegisterRegister 
 ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 

Pad the Video Output for TVs that do not Disp. a Full Image

 
Post new topic   Reply to topic    pyTivo Discussion Forum Forum Index -> Hacks
 View previous topic :: View next topic  
Author Message
dlfl



Joined: 04 Jan 2008
Posts: 40
Location: Ohio

PostPosted: Sun Feb 10, 2008 12:12 pm    Post subject: Pad the Video Output for TVs that do not Disp. a Full Image Reply with quote

On my old 4:3 CRT TV transferred videos are clipped at the top and on both sides.

Attached is a patch that pads the top (16 pixels) and both sides (20 pixels). It affects only function select_aspect in transcode.py. The diff is a "unified context" diff relative to transcode.py in version ebc6b29e44be3... in wmcbrine's git. This was current 7 Feb and transcode.py has not changed in the two versions committed from then until now.

The changes are only a few lines in three places. You can make them by simple editing by inspection of the diff file. (A '-' means delete that line; a '+' means add that line). You see two variables WPAD and TPAD that you can change to adjust the padding -- but always make them even whole numbers.

The patch is intended to affect only 4:3 aspect configurations but hasn't been tested on 16:9 cases.

I'm not proposing any developer incorporate this in their code. I don't know how many other users would want this, and to do it properly would add yet another config item.

I had to change the attached file extension from .diff to .txt .

_________________
TiVo 649 (Series 2 DT), Win XP Pro, Wired Ethernet
Try pyTivoMetaGen
VideoReDo users: try TVAP
Back to top
View user's profile Send private message
krkeegan
Site Admin


Joined: 04 Jan 2008
Posts: 412
Location: Los Angeles, CA

PostPosted: Sun Feb 10, 2008 4:27 pm    Post subject: Reply with quote

You just raised an interesting point. There are certainly going to be, and probably already are, other modifications that provide unique solutions.

This calls for another forum.
Back to top
View user's profile Send private message Visit poster's website
wmcbrine



Joined: 04 Jan 2008
Posts: 514

PostPosted: Mon Feb 11, 2008 11:04 am    Post subject: Reply with quote

krkeegan wrote:
You just raised an interesting point. There are certainly going to be, and probably already are, other modifications that provide unique solutions.

I don't see this as something unique -- almost every set has overscan. Something like this (whether or not it's exactly this) probably would be a good idea for general use.

I could even see making it vary by file type -- e.g., assume that MPEGs are intended for TV display (because they're probably from DVD, HDTV, or STB sources), and don't pad them; but assume that AVIs and MOVs are intended for computer display, so pad them to ensure that the full image shows up on a TV. That's probably not quite the way to go, either, but it's something to ponder.

Quote:
This calls for another forum.

I disagree. I thought there were too many subforums already. (Actually, I'm not sure any are needed.) But this topic, to me, fits perfectly under "Development".

_________________
My pyTivo fork
Back to top
View user's profile Send private message
krkeegan
Site Admin


Joined: 04 Jan 2008
Posts: 412
Location: Los Angeles, CA

PostPosted: Mon Feb 11, 2008 12:55 pm    Post subject: Reply with quote

Hmm, interesting, I haven't seen any overscan on any HD sets, including plasma, lcd, and dlp. My impression was that overscan was limited to crt based on the technology.
Back to top
View user's profile Send private message Visit poster's website
wmcbrine



Joined: 04 Jan 2008
Posts: 514

PostPosted: Mon Feb 11, 2008 4:42 pm    Post subject: Reply with quote

Not only are there plasma sets with overscan (like mine), there are also CRTs without (those intended as computer monitors rather than TVs).

Some HD sets allow toggling it. Sometimes it depends on the input used. Mine has no way to turn it off, but then it's technically an EDTV.

_________________
My pyTivo fork
Back to top
View user's profile Send private message
krkeegan
Site Admin


Joined: 04 Jan 2008
Posts: 412
Location: Los Angeles, CA

PostPosted: Mon Feb 11, 2008 5:13 pm    Post subject: Reply with quote

Interesting, I guess I assumed there was no reason to do this anymore.

Still, I am with dlfl on this one. I don't think this is a major problem for most people and I would rather not clutter up the list of settings or the program with settings that will only be used by a very very small subset of individuals.
Back to top
View user's profile Send private message Visit poster's website
wmcbrine



Joined: 04 Jan 2008
Posts: 514

PostPosted: Mon Feb 11, 2008 6:23 pm    Post subject: Reply with quote

krkeegan wrote:
Interesting, I guess I assumed there was no reason to do this anymore.

Even if overscan were limited to CRTs, even though CRTs are being phased out of retail, they're still the bulk of sets in use.

_________________
My pyTivo fork
Back to top
View user's profile Send private message
ciper



Joined: 17 Feb 2008
Posts: 3

PostPosted: Sun Feb 17, 2008 3:32 am    Post subject: Reply with quote

AFAIK all sets must have overscan. If there wasnt any you could see the close caption information at the top of the screen!
Back to top
View user's profile Send private message
wmcbrine



Joined: 04 Jan 2008
Posts: 514

PostPosted: Fri Feb 29, 2008 6:35 pm    Post subject: Reply with quote

Changed the subject line to reflect that this is actually about padding (or avoiding cropping).
_________________
My pyTivo fork
Back to top
View user's profile Send private message
rgr



Joined: 02 Mar 2008
Posts: 2

PostPosted: Sun Mar 02, 2008 1:59 pm    Post subject: Reply with quote

If anybody could add this it'd much appreciated. I have a Toshiba DLP tv and an overscan problem that I corrected by kluging together some code that does what I want. Problem is it's hardcoded in an old (12/07) version of pyTivo, so if I want to go to one of the new builds I have to figure out what to adjust and where each time. This is the first time I've seen or modded python code so it takes me awhile to do so.

I appreciate that it'd be a hassle to add another variable into the config file, but if you could, that'd be fantastic!

Thanks for all you folks do to make using my tivo even more of a pleasure and convenience than it already is.
Back to top
View user's profile Send private message
Display posts from previous:   
Post new topic   Reply to topic    pyTivo Discussion Forum Forum Index -> Hacks All times are GMT - 8 Hours
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You cannot download files in this forum
Site is in NO WAY affiliated with TiVo Inc

Powered by phpBB © 2001, 2005 phpBB Group
phpBB SEO
[ Time: 0.2968s ][ Queries: 13 (0.1997s) ][ Debug on ]